Add private property (required for workspaces with yarn)

Shopify · Apr 14, 2023 · 86226dd · 86226dd
1 parent ea71638
commit 86226dd
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 14 deletions.
diff --git a/packages/cli-kit/src/public/node/node-package-manager.ts b/packages/cli-kit/src/public/node/node-package-manager.ts
@@ -293,6 +293,12 @@ export interface PackageJson {
    *  The prettier attribute of the package.json
    */
   prettier?: string
+
+  /**
+   * The private attribute of the package.json.
+   * https://docs.npmjs.com/cli/v9/configuring-npm/package-json#private
+   */
+  private?: boolean
 }
 
 /**

diff --git a/packages/create-app/src/services/init.ts b/packages/create-app/src/services/init.ts
@@ -73,23 +73,26 @@ async function init(options: InitOptions) {
           const packageJSON = (await findUpAndReadPackageJson(templateScaffoldDir)).content
           packageJSON.name = hyphenizedName
           packageJSON.author = (await username()) ?? ''
-          if (packageManager === 'pnpm') {
-            await writeFile(
-              joinPath(templateScaffoldDir, 'pnpm-workspace.yaml'),
-              `packages:\n  - 'web'\n  - 'web/frontend'\n  - 'extensions/*'\n`,
-            )
-          } else {
-            packageJSON.workspaces = ['web', 'web/frontend', 'extensions/*']
+          packageJSON.private = true
+
+          switch (packageManager) {
+            case 'npm':
+            case 'yarn':
+              packageJSON.workspaces = ['web', 'web/frontend', 'extensions/*']
+              break
+            case 'pnpm':
+              await writeFile(
+                joinPath(templateScaffoldDir, 'pnpm-workspace.yaml'),
+                `packages:\n  - 'web'\n  - 'web/frontend'\n  - 'extensions/*'\n`,
+              )
+              // Ensure that the installation of dependencies doesn't fail when using
+              // pnpm due to missing peerDependencies.
+              await appendFile(joinPath(templateScaffoldDir, '.npmrc'), `auto-install-peers=true\n`)
+              break
           }
-          await updateCLIDependencies({packageJSON, local: options.local, directory: templateScaffoldDir})
 
+          await updateCLIDependencies({packageJSON, local: options.local, directory: templateScaffoldDir})
           await writePackageJSON(templateScaffoldDir, packageJSON)
-
-          // Ensure that the installation of dependencies doesn't fail when using
-          // pnpm due to missing peerDependencies.
-          if (packageManager === 'pnpm') {
-            await appendFile(joinPath(templateScaffoldDir, '.npmrc'), `auto-install-peers=true\n`)
-          }
         },
       },
     )