Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Customer JSON templates are no longer packaged #1249

Closed
2 tasks done
bertiful opened this issue Jan 30, 2023 · 0 comments · Fixed by #1250
Closed
2 tasks done

[Bug]: Customer JSON templates are no longer packaged #1249

bertiful opened this issue Jan 30, 2023 · 0 comments · Fixed by #1250
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working

Comments

@bertiful
Copy link

bertiful commented Jan 30, 2023

Issue most likely introduced in afe5415, specifically:

const themeDirectoriesPattern = [
'assets',
'config',
'layout',
'locales',
'sections',
'snippets',
'templates',
'release-notes.md',
].join('/**|')
.

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

JSON templates for templates/customers should be included in the zip after running shopify theme package.

Actual behavior

Running shopify theme package builds all files except the following: templates/customers/*.json.

Reproduction steps

  1. Update to latest Shopify CLI Current Shopify CLI version: 3.39.0
  2. Run shopify theme package
  3. Open zip file and navigate to templates/ directory

Operating System

Mac OS Ventura 13.0

Shopify CLI version (check your project's package.json if you're not sure)

3.39.0

Shell

zsh

Node version (run node -v if you're not sure)

v18.13.0

What language and version are you using in your application?

No response

@bertiful bertiful added the Type: Bug Something isn't working label Jan 30, 2023
@mgmanzella mgmanzella self-assigned this Jan 30, 2023
@Arkham Arkham added the Area: @shopify/theme @shopify/theme package issues label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants