UI Kit UX improvements #1278
Merged
UI Kit UX improvements #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Benchmark reportThe following table contains a summary of the startup time for all commands.
|
matteodepalo
requested review from
a team,
amcaplan and
gonzaloriestra
and removed request for
a team
Coverage report
Show new covered files 🐣
Test suite run success973 tests passing in 500 suites. Report generated by 🧪jest coverage report action from a52e125 |
gonzaloriestra
approved these changes
Feb 6, 2023
| @@ -14,6 +14,7 @@ export interface SelectPromptProps<T> { | |||
| onSubmit: (value: T) => void | |||
| infoTable?: InfoTableProps['table'] | |||
| defaultValue?: T | |||
| submitWithShortcuts?: boolean | |||
There was a problem hiding this comment.
Wouldn't it be a bit confusing if we have a flow where the first question requires you to hit enter after choosing an answer, but then the second time you don't have to?
What about submitting always without pressing enter?
There was a problem hiding this comment.
Personally I'm ok with the recommendation, but for some reason we converged on having shortcuts only jump to the selection for longer lists. @MeredithCastile do you remember why?
There was a problem hiding this comment.
Ok, thanks. Let's move on and we can change it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We'd like to make some UX improvements to UI kit.
WHAT is this pull request doing?
This PR packs the following improvements:
bannerssub-command tostaticrenderConfirmationPromptswill now allow users to to submit answers just by pressing shortcuts, without also having to press enter.How to test your changes?
shopify kitchen-sink staticand see the new tableshopify app dev --resetand try to submitCreate this project as a new app on Shopify?just by pressingyorn.Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.