Make sure that the preview banner is shown when there is no web folder #1292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/internal-cli-foundations/issues/550
We weren't showing the footer with the preview url in
dev
if there was no web folder and only UI extensionsWHAT is this pull request doing?
This PR makes sure that the
previewUrl
is initialized outside the check forweb
or backend. Note that if we had function or theme extensions only, we would still not show the banner, but this is temporary while we're moving the instructions for both to the dev console.How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.