Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme extensions not being bundled when there are no other ui extensions #1319

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Feb 8, 2023

WHY are these changes introduced?

A bug was reported that theme extensions were not being uploaded. It's true in the case where you don't have other UI extensions.

Fixes #1311

WHAT is this pull request doing?

  • Enable bundling if there are any ui OR theme extensions.

How to test your changes?

  • Create a new project with just a theme app extension and try to deploy, you should see a new version in your partners dashboard

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline (avg) Current (avg) Diff
🟢 app build 921.33 ms 951.67 ms 3.29 %
🟢 app deploy 1132.67 ms 1150 ms 1.53 %
🟢 app dev 1131.67 ms 1132.33 ms 0.06 %
🟢 app env pull 1021.33 ms 1039.33 ms 1.76 %
🟢 app env show 1026 ms 1044 ms 1.75 %
🟢 app function build 921.33 ms 932.33 ms 1.19 %
🟢 app function run 909.67 ms 934 ms 2.67 %
🟢 app function schema 1060.67 ms 1072.67 ms 1.13 %
🟢 app function typegen 912.33 ms 930.67 ms 2.01 %
🟢 app generate extension 1087.67 ms 1104.67 ms 1.56 %
🟢 app generate schema 1046.33 ms 1068.33 ms 2.1 %
🟢 app info 1022 ms 1045.33 ms 2.28 %
🟢 app scaffold extension 1091 ms 1107.33 ms 1.5 %
🟢 app update-url 996.67 ms 1037.33 ms 4.08 %
🟢 theme check 871 ms 871.67 ms 0.08 %
🟢 theme delete 981 ms 994.33 ms 1.36 %
🟢 theme dev 981 ms 986.67 ms 0.58 %
🟢 theme help-old 856.33 ms 870 ms 1.6 %
🟢 theme info 910 ms 923.67 ms 1.5 %
🟢 theme init 882.33 ms 896.33 ms 1.59 %
🟢 theme language-server 860.67 ms 860.33 ms -0.04 %
🟢 theme list 979 ms 991.67 ms 1.29 %
🟢 theme open 982 ms 994.67 ms 1.29 %
🟢 theme package 906 ms 915.67 ms 1.07 %
🟢 theme publish 984.67 ms 993 ms 0.85 %
🟢 theme pull 979.67 ms 988 ms 0.85 %
🟢 theme push 980 ms 1016.67 ms 3.74 %
🟢 theme serve 985.33 ms 1002.67 ms 1.76 %
🟢 theme share 972.33 ms 990.33 ms 1.85 %
🟢 webhook trigger 968.33 ms 997.67 ms 3.03 %

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.46% (+1.62% 🔼)
4099/5580
🟡 Branches
70.43% (+0.82% 🔼)
1846/2621
🟡 Functions
71.58% (+1.66% 🔼)
1078/1506
🟡 Lines
74.82% (+1.67% 🔼)
3913/5230

Test suite run success

1029 tests passing in 528 suites.

Report generated by 🧪jest coverage report action from 830617a

@Arkham Arkham merged commit 44a9963 into main Feb 8, 2023
@Arkham Arkham deleted the fix-theme-extension-bundle branch February 8, 2023 14:30
@shopify-shipit shopify-shipit bot temporarily deployed to production February 8, 2023 14:48 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly February 9, 2023 02:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to deploy Teme app extension
3 participants