Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest javy #1328

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Update to latest javy #1328

merged 2 commits into from
Feb 8, 2023

Conversation

Arkham
Copy link
Contributor

@Arkham Arkham commented Feb 8, 2023

WHY are these changes introduced?

The version of Javy that we use is broken on windows

WHAT is this pull request doing?

Updates to latest version of javy

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-developer-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@Arkham Arkham force-pushed the update-to-latest-javy branch from c379791 to dd3d0c8 Compare February 8, 2023 17:48
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline (avg) Current (avg) Diff
🟢 app build 1098.67 ms 1080.33 ms -1.67 %
🟢 app deploy 1328.33 ms 1345 ms 1.25 %
🟢 app dev 1313.33 ms 1324.33 ms 0.84 %
🟢 app env pull 1198.33 ms 1205.67 ms 0.61 %
🟢 app env show 1206.33 ms 1199 ms -0.61 %
🟢 app function build 1081.33 ms 1076.33 ms -0.46 %
🟢 app function run 1063 ms 1068 ms 0.47 %
🟢 app function schema 1224.67 ms 1234 ms 0.76 %
🟢 app function typegen 1071 ms 1081.67 ms 1 %
🟢 app generate extension 1282 ms 1295 ms 1.01 %
🟢 app generate schema 1243 ms 1247 ms 0.32 %
🟢 app info 1201 ms 1224 ms 1.92 %
🟢 app scaffold extension 1284.33 ms 1287.33 ms 0.23 %
🟢 app update-url 1183.33 ms 1186.33 ms 0.25 %
🟢 theme check 1014.67 ms 1053 ms 3.78 %
🟢 theme delete 1164.67 ms 1157.33 ms -0.63 %
🟢 theme dev 1151.67 ms 1154 ms 0.2 %
🟢 theme help-old 1010 ms 1019 ms 0.89 %
🟢 theme info 1065.33 ms 1085.33 ms 1.88 %
🟢 theme init 1034.33 ms 1032.67 ms -0.16 %
🟢 theme language-server 1013 ms 1036 ms 2.27 %
🟢 theme list 1147.67 ms 1156.67 ms 0.78 %
🟢 theme open 1162.33 ms 1156.67 ms -0.49 %
🟢 theme package 1058.33 ms 1072.67 ms 1.35 %
🟢 theme publish 1149.33 ms 1139.33 ms -0.87 %
🟢 theme pull 1157.67 ms 1156.33 ms -0.12 %
🟢 theme push 1152.67 ms 1163.33 ms 0.93 %
🟢 theme serve 1158 ms 1163.67 ms 0.49 %
🟢 theme share 1139.67 ms 1150.67 ms 0.97 %
🟢 webhook trigger 1160.33 ms 1179 ms 1.61 %

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.46% (-0.22% 🔻)
4099/5580
🟡 Branches
70.43% (-0.15% 🔻)
1846/2621
🟡 Functions
71.58% (-0.13% 🔻)
1078/1506
🟡 Lines
74.82% (-0.21% 🔻)
3913/5230
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / trigger.ts
100%
87.5% (-7.5% 🔻)
100% 100%

Test suite run success

1029 tests passing in 528 suites.

Report generated by 🧪jest coverage report action from dd3d0c8

@Arkham Arkham merged commit 79449e7 into main Feb 8, 2023
@Arkham Arkham deleted the update-to-latest-javy branch February 8, 2023 18:05
@shopify-shipit shopify-shipit bot temporarily deployed to production February 8, 2023 18:32 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly February 9, 2023 02:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants