Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that prevents shopify theme console from evaluating results when another 'preview_theme_id' is set #3811

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Apr 30, 2024

WHY are these changes introduced?

When another theme is set in the session, shopify theme console tries to evaluate Liquid snippets using the wrong remote theme.

WHAT is this pull request doing?

This PR adopts this fix to make sure that Liquid snippets are evaluated using the expected remote theme.

How to test your changes?

Before

After

Post-release steps

None.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@karreiro karreiro requested a review from lucyxiang April 30, 2024 07:22
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.79% 6942/9670
🟡 Branches 68.71% 3419/4976
🟡 Functions 71.22% 1858/2609
🟡 Lines 73.09% 6543/8952

Test suite run success

1633 tests passing in 763 suites.

Report generated by 🧪jest coverage report action from 5343a36

Copy link
Contributor

@lucyxiang lucyxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Guilherme 🙏

@karreiro karreiro added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 2588def Apr 30, 2024
@karreiro karreiro deleted the preview-theme-id-console-main branch April 30, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants