Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customer login functionality during development #4364

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

montalvomiguelo
Copy link
Contributor

@montalvomiguelo montalvomiguelo commented Aug 22, 2024

WHY are these changes introduced?

Fixes #4270

WHAT is this pull request doing?

Preserves _shopify_essential cookie to prevent session loss.

How to test your changes?

Serve a theme, then log in as a customer.

login.mp4

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@montalvomiguelo montalvomiguelo changed the title Preserve _shopify_essential cookie to allow logging in Fix customer login functionality during development Aug 25, 2024
@yhc44
Copy link

yhc44 commented Aug 26, 2024

Hello, is there any plan when you want to merge this?

This is a crucial feature for me, because i am developing mainly in customer accounts at the moment. The only way for me to see local changes is using the Theme Preview Url.

@karreiro karreiro self-requested a review August 28, 2024 12:59
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @montalvomiguelo!

@karreiro karreiro added this pull request to the merge queue Aug 30, 2024
Merged via the queue into Shopify:main with commit c927788 Aug 30, 2024
66 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't log in as a customer via the Shopify CLI
3 participants