Avoid errors when trying to output empty variables #4513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://app.bugsnag.com/shopify/cli/errors/64b0013d044bd600081193c1
WHAT is this pull request doing?
We don't want verbose output messages to make the command fail when a variable is undefined.
In this case, if the store variable is needed, it will fail later in a more controlled way:
How to test your changes?
I couldn't find a real situation when this happens, but it can be reproduced this way:
rm ~/Library/Preferences/shopify-cli-theme-conf-nodejs/config.json
outputDebug(outputContent`Store: ${getThemeStore()}`)
p shopify theme info --verbose
Measuring impact
How do we know this change was effective? Please choose one:
Checklist