-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension targeting preloads #4652
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1918 tests passing in 871 suites. Report generated by 🧪jest coverage report action from 851867c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
This comment has been minimized.
This comment has been minimized.
7526d82
to
aeeea8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things in the test, otherwise all good!
packages/app/src/cli/models/extensions/specifications/ui_extension.test.ts
Outdated
Show resolved
Hide resolved
packages/app/src/cli/models/extensions/specifications/ui_extension.test.ts
Outdated
Show resolved
Hide resolved
--- | ||
'@shopify/app': patch | ||
--- | ||
|
||
added extensions.targeting.preloads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to run pnpm changeset add
from the root, if you run it inside packages/app
it won't work and adds a few extra files. (You'd need to delete packages/app/.changeset
)
ff6d8d7
to
851867c
Compare
WHY are these changes introduced?
closes https://github.com/Shopify/checkout-web/issues/39215
addresses part of https://github.com/Shopify/shopify/issues/545531 which implements
extension.targeting.preloads
as defined in this PR.We need to introduce a preloading concept for UI extensions to statically define URLs preloads ahead of time for security and performance.
WHAT is this pull request doing?
adding needed schemas to support the above static configurations for UI extensions.
How to test your changes?
pnpm run deploy
should insert the records correctly.Measuring impact
How do we know this change was effective? Please choose one:
Checklist