Fix theme dev session

[isaacroldan]

WHY are these changes introduced?

theme dev needs a valid session at all times, so we need to take care of refreshing the tokens before they expire.
A bug was introduced where the 90min interval was causing theme dev to just stop instead of properly refresh the session.

Fixes #781

WHAT is this pull request doing?

• Remove promises from inside the setInterval function, as it doesn't play well with awaits (but we don't need them)
• Add a sleep call to keep the server running for up to 24h
• Add some defensive code so that the ruby process termination can't propagate the termination to the node process.

How to test your changes?

• theme dev for at least 2h, the session should be refreshed automatically and the server restarted.

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	68.1% (-0.12% 🔻)	3563/5232
🟡	Branches	62.5% (+0.07% 🔼)	1150/1840
🟡	Functions	66.18% (-0.07% 🔻)	902/1363
🟡	Lines	68.27% (-0.1% 🔻)	3387/4961

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🔴	... / content-tokens.ts	44.44% (-3.7% 🔻)	20% (-10% 🔻)	47.37%	44.44% (-3.7% 🔻)
🔴	... / system.ts	42.55% (-6.16% 🔻)	36.36% (-5.74% 🔻)	33.33% (-3.03% 🔻)	44.44% (-4.27% 🔻)
🔴	... / common.ts	58.33% (-4.63% 🔻)	50% (-4.55% 🔻)	87.5%	56.52% (-5.02% 🔻)

Test suite run success

872 tests passing in 441 suites.

Report generated by 🧪jest coverage report action from e912857

[pepicrft]

@isaacroldan did this end up working?

[isaacroldan]

Yes and no, it refreshes the tokens and starts a new ruby process. But on windows it fails to terminate old processes, so you end up with multiple theme dev servers running at the same time.
Still need to dedicate some time to figure it out, probably early next week.

[matteodepalo]

I'm curious, after this fix, do we still need to treat windows differently here? It might be the case that now we can just kill the tree correctly with the previous code on windows as well.

[isaacroldan]

You mean to remove the windowsHide property?