Enable password flag for theme dev

.changeset/old-chefs-smash.md

@@ -0,0 +1,5 @@
+---
+'@shopify/cli-kit': minor
+---
+
+Upgrade CLI 2.0 and theme-check dependencies

.changeset/serious-cherries-cheer.md

@@ -0,0 +1,7 @@
+---
+'@shopify/cli': minor
+'@shopify/theme': minor
+'@shopify/cli-kit': patch
+---
+
+Enable password flag for theme dev

packages/cli-kit/src/output.ts

@@ -357,7 +357,7 @@ export function getOutputUpdateCLIReminder(
   const versionMessage = `💡 Version ${version} available!`
   if (!packageManager || packageManager === 'unknown') return versionMessage
 
-  const updateCommand = token.packagejsonScript(packageManager, 'shopify', 'upgrade')
+  const updateCommand = token.packagejsonScript(packageManager, 'shopify upgrade')
   return content`${versionMessage} Run ${updateCommand}`.value
 }
 

packages/cli-kit/src/public/node/ruby.ts

@@ -11,8 +11,8 @@ import {platformAndArch} from '../../os.js'
 import {AbortSignal} from 'abort-controller'
 import {Writable} from 'node:stream'
 
-const RubyCLIVersion = '2.32.0'
-const ThemeCheckVersion = '1.10.3'
+const RubyCLIVersion = '2.33.0'
+const ThemeCheckVersion = '1.12.1'
 const MinBundlerVersion = '2.3.8'
 const MinRubyVersion = '2.7.5'
 

packages/cli-kit/src/session.test.ts

@@ -286,6 +286,14 @@ describe('ensureAuthenticatedStorefront', () => {
     expect(got).toEqual('storefront_token')
   })
 
+  it('returns the password if provided', async () => {
+    // Given/When
+    const got = await ensureAuthenticatedStorefront([], 'theme_access_password')
+
+    // Then
+    expect(got).toEqual('theme_access_password')
+  })
+
   it('throws error if there is no storefront token', async () => {
     // Given
     vi.mocked(validateSession).mockResolvedValueOnce('ok')

packages/cli-kit/src/session.ts

@@ -115,7 +115,12 @@ ${token.json(scopes)}
  * @param scopes - Optional array of extra scopes to authenticate with.
  * @returns The access token for the Storefront API.
  */
-export async function ensureAuthenticatedStorefront(scopes: string[] = []): Promise<string> {
+export async function ensureAuthenticatedStorefront(
+  scopes: string[] = [],
+  password: string | undefined = undefined,
+): Promise<string> {
+  if (password) return password
+
   debug(content`Ensuring that the user is authenticated with the Storefront API with the following scopes:
 ${token.json(scopes)}
 `)

packages/theme/src/cli/commands/theme/dev.ts

@@ -68,6 +68,7 @@ export default class Dev extends ThemeCommand {
       description: 'Proceed without confirmation, if current directory does not seem to be theme directory.',
       env: 'SHOPIFY_FLAG_FORCE',
     }),
+    password: themeFlags.password,
   }
 
   static cli2Flags = [
@@ -108,18 +109,18 @@ export default class Dev extends ThemeCommand {
       controller.abort()
       controller = new abort.Controller()
       // eslint-disable-next-line @typescript-eslint/no-floating-promises
-      this.execute(store, command, controller)
+      this.execute(store, flags.password, command, controller)
     }, this.ThemeRefreshTimeoutInMs)
 
     // eslint-disable-next-line @typescript-eslint/no-floating-promises
-    this.execute(store, command, controller)
+    this.execute(store, flags.password, command, controller)
     await system.sleep(this.HardTimeoutInSeconds)
     clearInterval(refreshThemeSessionInterval)
   }
 
-  async execute(store: string, command: string[], controller: abort.Controller) {
-    const adminSession = await session.ensureAuthenticatedThemes(store, undefined, [], true)
-    const storefrontToken = await session.ensureAuthenticatedStorefront()
+  async execute(store: string, password: string | undefined, command: string[], controller: abort.Controller) {
+    const adminSession = await session.ensureAuthenticatedThemes(store, password, [], true)
+    const storefrontToken = await session.ensureAuthenticatedStorefront([], password)
     return execCLI2(command, {adminSession, storefrontToken, signal: controller.signal})
   }
 }