This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
Updates the Number widget to use floats or integers #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exactly what I was looking for, thanks @pallan! |
This was referenced Aug 26, 2014
Open
| @@ -22,3 +22,8 @@ class Dashing.Number extends Dashing.Widget | |||
| c.replace /\bstatus-\S+/g, '' | |||
| # add new class | |||
| $(@get('node')).addClass "status-#{data.status}" | |||
|
|
|||
| parseValue: (number) -> | |||
| if number == parseInt(number, 10) then parseInt(number) else parseFloat(number) | |||
There was a problem hiding this comment.
If number has non-numeric digits, this function will assume it is a float.
For example: @parseValue("15px") should return 15, but would return the float 15.0 instead.
Not sure if this is a big deal, but it would be confusing if it happened and you weren't aware of this. Seems like an edge case to me though.
|
Seems like a sensible change, except for the edge case I bring up in the note above. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently implemented number widget only supports integers when calculating the difference. We were using it with NewRelic's response time metric which is returned in milliseconds but we wanted to show in seconds (200ms vs 0.200s). However, since the JS used parseInt it changed the floats to zero (0) and never showed a valid difference. There were a couple of pull requests already that just changed parseInt to parseFloat. This PR updated the JS to detect if the supplied values are floats or integers and then use the appropriate parser for the value, thereby, supporting both types.