Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Enable data suffix #438

Merged
merged 1 commit into from
Jun 8, 2015
Merged

Enable data suffix #438

merged 1 commit into from
Jun 8, 2015

Conversation

schinken
Copy link
Contributor

@schinken schinken commented Sep 9, 2014

This simple patch enables a suffix similar to the number widget for graphs.

@terraboops
Copy link
Contributor

To clarify, this allows a suffix to be added to the Current Value via a data-suffix attribute on the Graph Widget.

Very small change, seems useful, 👍 for merging.

That being said, this change relies on batman.js -- which Dashing will be moving away from due to it's deprecation. So if it is merged, it will be deleted when version 2 finally awakens.

@pushmatrix
Copy link
Member

Well said @tylermauthe

pushmatrix added a commit that referenced this pull request Jun 8, 2015
Add the data suffix for the graph widget
@pushmatrix pushmatrix merged commit 203abd6 into Shopify:master Jun 8, 2015
gottfrois added a commit to gottfrois/dashing-rails that referenced this pull request Jul 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants