Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border Radius not applying to placeholder images #2684

Closed
1 task
kimberlyoleiro opened this issue Jun 1, 2023 · 1 comment
Closed
1 task

Border Radius not applying to placeholder images #2684

kimberlyoleiro opened this issue Jun 1, 2023 · 1 comment
Assignees

Comments

@kimberlyoleiro
Copy link

kimberlyoleiro commented Jun 1, 2023

User Story As a merchant installing a new theme to use for my online store, I should be able to see an accurate representation of what my theme will look like with or without placeholder content. What I see by default, should reflect what I'll see when I upload a real image

Ultimate Goal: Achieve a 1:1 experience between placeholders images and real images

More context: With the introduction of new placeholder content, and fresh eyes on the topic, we noticed some inconsistencies between the empty and populated states with images. Notes here

Identified Problem:

The border radius of product, collection, and blog cards is not applying to the placeholder images. This is appearing in the Collage, Featured Collection, Recommended Product Sections

Expected behaviour

  • The default styles of product, collection, and blog cards placeholder images should appear with the same styles as a if they were populated with real product, collection, and blog images.

Image

Task

  • Ensure border radius applies product, collection, and blog cards placeholder images
@kimberlyoleiro
Copy link
Author

fixes #2684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants