Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow block settings info text #1019

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Slideshow block settings info text #1019

merged 2 commits into from
Dec 16, 2021

Conversation

ludoboludo
Copy link
Contributor

Why are these changes introduced?

Fixes #1009

What approach did you take?

Add help text to match other sections.

Other considerations

Demo links

Checklist

@ludoboludo ludoboludo requested a review from katycobb December 14, 2021 21:03
@katycobb
Copy link
Contributor

Looks good, thank you!

katycobb
katycobb previously approved these changes Dec 14, 2021
@melissaperreault melissaperreault self-requested a review December 15, 2021 21:11
Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@ludoboludo
Copy link
Contributor Author

Ill wait on the translations and merge once I got them all back 👍

@ludoboludo
Copy link
Contributor Author

Alright, all translations were received. Could I get your approval again on this @katycobb & @melissaperreault ?

@ludoboludo ludoboludo merged commit 4e19c53 into main Dec 16, 2021
@ludoboludo ludoboludo deleted the slideshow-help-text branch December 16, 2021 18:00
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slideshow help text
3 participants