Image with text UI polish #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tyleralsbury
previously approved these changes
Jul 6, 2021
|
Looks good @tauthomas01 Just one note:
|
|
@Oliviammarcello it should be good now: https://os2-demo.myshopify.com/admin/themes/120658165782/editor |
Oliviammarcello
approved these changes
Jul 7, 2021
sofiamatulis
approved these changes
Jul 7, 2021
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Image with text polish * Update from Shopify for theme dawn/feature-image-with-text-ui * adjust spacing on button and heading * revert index.json and settings data Co-authored-by: shopify-online-store[bot] <79544226+shopify-online-store[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #26
What approach did you take?
Most of the changes were already done previously. I made spacing change based on this:
Demo links
Checklist