Use og:type=website for collection
#1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<meta property="og:type" content="product.group" />` is not actually a valid value. Collection page should default to `<meta property="og:type" content="website" />` instead. cc: @jackson-lo
ludoboludo
reviewed
Feb 1, 2022
There was a problem hiding this comment.
Thanks for bringing this up.
If this needs to be changed, I think we will have to follow up to get it updated here in our docs as well: https://shopify.github.io/liquid-code-examples/example/open-graph-tags
|
@ludoboludo would you be able to do that change? |
No I think I would need to find which team owns that. I'd start asking in |
ludoboludo
approved these changes
Feb 2, 2022
|
@ludoboludo is there a way you can get another reviewer for me or use your power to merge? |
andrewetchen
approved these changes
Feb 18, 2022
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
`<meta property="og:type" content="product.group" />` is not actually a valid value. Collection page should default to `<meta property="og:type" content="website" />` instead. cc: @jackson-lo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<meta property="og:type" content="product.group" />is not actually a valid value. Collection page should default to<meta property="og:type" content="website" />instead.cc: @jackson-lo
Why are these changes introduced?
Fixes #0.
What approach did you take?
Other considerations
Demo links
Checklist