Remove all uses of inset #1369
Merged
Remove all uses of inset #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaichenWang
approved these changes
Feb 16, 2022
|
Partially addresses #1376 |
ludoboludo
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Looks good 👍
One thing I noticed while testing is the odd image sizing in the cart: screenshot. Which we could prevent by adding align-items: flex-start on the parent div of the image. It happens on version 14 of iOS.
|
Created an issue for what I mentioned in my comment: #1409 |
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Removes all uses css
insetprop. Support for this property is probably technically just short of the "last 2 versions" requirement. https://caniuse.com/mdn-css_properties_insetWhat approach did you take?
Replace with good ol' top, bottom, left, right
Other considerations
Testing steps/scenarios
Demo links
Checklist