Fix bad CLS score on main product when video is the featured media #1412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #1165
What approach did you take?
There are 80 lines of CSS in
component-deferred-media.css
which were loaded asynchronously onmain-product.iquid
and a few other files.I've changed it so the asset is loaded right away so that if some of the first medias are videos then it won't cause any CLS issues.
Before and after lighthouse scores on mobile:

Other considerations
A few other files do call that file asynchronously, so that problem might happen there as well but because it's section it's not possible for us to say if they're going to be the first thing loading at the top of the page or not.
Here is the list of places:
Testing steps/scenarios
Test 3D models, video
product which is showing on the home page and feat. collection, using lighthouse in the inspect tool. Test for mobile and desktop.Demo links
Checklist