[Product page] Making the sticky content more flexible #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenekasimov
approved these changes
Nov 14, 2022
LucasLacerdaUX
approved these changes
Nov 21, 2022
melissaperreault
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Thanks Ludo! 🎉 I tested various scenarios and the one below and works as expected! 🚢
- Test with and without sticky setting on. Screenshot
- test on pages with longer media column, eg: Louise sandal with the unhidden variants (screenshot)
- test on pages with longer product content column, eg: Shoe test variant product
- test all media layout options, eg: medias on the left, stacked, 2 columns, thumbnail (screenshot)
- test the product modal
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Making the sticky content more flexible * unify the class name and edit the references in the quick add styling * fix class name * Rebase tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
We're currently applying the sticky behaviour in a pretty opinionated way on the media column or product info one.
This PR aims to make it a lot more flexible to work in whatever content the merchant has (not a lot of images and a long description or the other way around).
Why are these changes introduced?
Fixes #0.
What approach did you take?
I applied the sticky class on both columns at all time instead of conditionally.
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Shoe test variant productDemo links
Checklist