Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image setting updates #2148

Merged
merged 6 commits into from
Dec 19, 2022
Merged

Image setting updates #2148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
70e545b
Update height settings for image banner, slideshow, image with text
kmeleta Nov 9, 2022
a9acd57
Setting schema updates
kmeleta Nov 28, 2022
2ea981e
Update 17 translation files
translation-platform[bot] Dec 9, 2022
cdbb6b3
Update 2 translation files
translation-platform[bot] Dec 12, 2022
53be1ad
Update 1 translation file
translation-platform[bot] Dec 16, 2022
288e267
Fix formatting
kmeleta Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions assets/component-image-with-text.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
height: 19.4rem;
}

.image-with-text__media--medium {
height: 29.6rem;
}

.image-with-text__media--large {
height: 43.5rem;
}
Expand All @@ -30,6 +34,10 @@
height: 31.4rem;
}

.image-with-text__media--medium {
height: 46rem;
}

.image-with-text__media--large {
height: 69.5rem;
}
Expand Down
18 changes: 12 additions & 6 deletions locales/cs.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "Výška banneru",
"options__1": {
"label": "Malá"
"label": "Přizpůsobení prvnímu obrázku"
},
"options__2": {
"label": "Střední"
"label": "Malý"
},
"options__3": {
"label": "Velká"
"label": "Střední"
},
"info": "Nejlepších výsledků dosáhnete použitím obrázku s poměrem stran 3:2. [Zjistit více](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "Nejlepších výsledků dosáhnete použitím obrázku s poměrem stran 3:2. [Zjistit více](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "Velký"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "Malá"
},
"options__3": {
"label": "Velká"
"label": "Střední"
},
"label": "Výška obrázku"
"label": "Výška obrázku",
"options__4": {
"label": "Velký"
}
},
"layout": {
"options__1": {
Expand Down
18 changes: 12 additions & 6 deletions locales/da.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "Bannerhøjde",
"options__1": {
"label": "Lille"
"label": "Tilpas til første billede"
},
"options__2": {
"label": "Medium"
"label": "Lille"
},
"options__3": {
"label": "Stor"
"label": "Mellem"
},
"info": "Brug et billede med et højde-bredde-forhold på 3:2 for at opnå det bedste resultat. [Få mere at vide](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "Brug et billede med et højde-bredde-forhold på 3:2 for at opnå det bedste resultat. [Få mere at vide](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "Stor"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "Lille"
},
"options__3": {
"label": "Stor"
"label": "Mellem"
},
"label": "Billedhøjde"
"label": "Billedhøjde",
"options__4": {
"label": "Stor"
}
},
"layout": {
"options__1": {
Expand Down
18 changes: 12 additions & 6 deletions locales/de.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "Bannerhöhe",
"options__1": {
"label": "Klein"
"label": "An erstes Bild anpassen"
},
"options__2": {
"label": "Mittel"
"label": "Klein"
},
"options__3": {
"label": "Groß"
"label": "Mittel"
},
"info": "Verwende für Bilder ein Seitenverhältnis von 3:2 für optimale Ergebnisse. [Mehr Informationen](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "Verwende für Bilder ein Seitenverhältnis von 3:2 für optimale Ergebnisse. [Mehr Informationen](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "Groß"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "Klein"
},
"options__3": {
"label": "Groß"
"label": "Mittel"
},
"label": "Bildhöhe"
"label": "Bildhöhe",
"options__4": {
"label": "Groß"
}
},
"layout": {
"options__1": {
Expand Down
10 changes: 8 additions & 2 deletions locales/en.default.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,12 +1046,15 @@
"image_height": {
"label": "Banner height",
"options__1": {
"label": "Small"
"label": "Adapt to first image"
},
"options__2": {
"label": "Medium"
"label": "Small"
},
"options__3": {
"label": "Medium"
},
"options__4": {
"label": "Large"
},
"info": "For best results, use an image with a 3:2 aspect ratio. [Learn more](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
Expand Down Expand Up @@ -1203,6 +1206,9 @@
"label": "Small"
},
"options__3": {
"label": "Medium"
},
"options__4": {
"label": "Large"
},
"label": "Image height"
Expand Down
18 changes: 12 additions & 6 deletions locales/es.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "Altura del banner",
"options__1": {
"label": "Pequeña"
"label": "Adaptar a la primera imagen"
},
"options__2": {
"label": "Mediana"
"label": "Pequeño"
},
"options__3": {
"label": "Grande"
"label": "Mediano"
},
"info": "Para resultados óptimos, utiliza una imagen con una relación de aspecto 3:2. [Más información](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "Para resultados óptimos, utiliza una imagen con una relación de aspecto 3:2. [Más información](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "Grande"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "Pequeño"
},
"options__3": {
"label": "Grande"
"label": "Mediano"
},
"label": "Altura de imagen"
"label": "Altura de imagen",
"options__4": {
"label": "Grande"
}
},
"layout": {
"options__1": {
Expand Down
18 changes: 12 additions & 6 deletions locales/fi.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "Bannerin korkeus",
"options__1": {
"label": "Pieni"
"label": "Mukauta ensimmäisen kuvan mukaan"
},
"options__2": {
"label": "Keskisuuri"
"label": "Pieni"
},
"options__3": {
"label": "Suuri"
"label": "Keskisuuri"
},
"info": "Saat parhaat tulokset käyttämällä kuvaa, jonka kuvasuhde on 3:2. [Lisätietoja](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "Saat parhaat tulokset käyttämällä kuvaa, jonka kuvasuhde on 3:2. [Lisätietoja](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "Suuri"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "Pieni"
},
"options__3": {
"label": "Suuri"
"label": "Keskisuuri"
},
"label": "Kuvan korkeus"
"label": "Kuvan korkeus",
"options__4": {
"label": "Suuri"
}
},
"layout": {
"options__1": {
Expand Down
18 changes: 12 additions & 6 deletions locales/fr.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "Hauteur de la bannière",
"options__1": {
"label": "Petit"
"label": "Adapter à la première image"
},
"options__2": {
"label": "Moyen"
"label": "Petit"
},
"options__3": {
"label": "Grand"
"label": "Moyen"
},
"info": "Pour optimiser vos résultats, utilisez une image ayant un rapport d'aspect de 3:2. [En savoir plus](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "Pour optimiser vos résultats, utilisez une image ayant un rapport d'aspect de 3:2. [En savoir plus](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "Grand"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "Petit"
},
"options__3": {
"label": "Grand"
"label": "Moyen"
},
"label": "Hauteur de l'image"
"label": "Hauteur de l'image",
"options__4": {
"label": "Grand"
}
},
"layout": {
"options__1": {
Expand Down
18 changes: 12 additions & 6 deletions locales/it.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "Altezza banner",
"options__1": {
"label": "Piccola"
"label": "Adatta alla prima immagine"
},
"options__2": {
"label": "Media"
"label": "Piccola"
},
"options__3": {
"label": "Grande"
"label": "Media"
},
"info": "Per un risultato ottimale, utilizza un'immagine con proporzioni 3:2. [Maggiori informazioni](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "Per un risultato ottimale, utilizza un'immagine con proporzioni 3:2. [Maggiori informazioni](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "Grande"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "Piccola"
},
"options__3": {
"label": "Grande"
"label": "Media"
},
"label": "Altezza immagine"
"label": "Altezza immagine",
"options__4": {
"label": "Grande"
}
},
"layout": {
"options__1": {
Expand Down
18 changes: 12 additions & 6 deletions locales/ja.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "バナーの高さ",
"options__1": {
"label": "小"
"label": "最初の画像に合わせる"
},
"options__2": {
"label": "中"
"label": "小"
},
"options__3": {
"label": "大"
"label": "中"
},
"info": "画像のアスペクト比が3:2のものを使用すると最適です。[詳しくはこちら](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "画像のアスペクト比が3:2のものを使用すると最適です。[詳しくはこちら](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "大"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "小"
},
"options__3": {
"label": "大"
"label": "中"
},
"label": "画像の高さ"
"label": "画像の高さ",
"options__4": {
"label": "大"
}
},
"layout": {
"options__1": {
Expand Down
18 changes: 12 additions & 6 deletions locales/ko.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,15 +916,18 @@
"image_height": {
"label": "배너 높이",
"options__1": {
"label": "작게"
"label": "첫 번째 이미지에 맞춤"
},
"options__2": {
"label": "보통"
"label": "작게"
},
"options__3": {
"label": "크게"
"label": "보통"
},
"info": "최고의 결과를 얻으려면 이미지의 가로 세로 비율을 3:2로 사용하십시오. [자세히 알아보기](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)"
"info": "최고의 결과를 얻으려면 이미지의 가로 세로 비율을 3:2로 사용하십시오. [자세히 알아보기](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)",
"options__4": {
"label": "크게"
}
},
"desktop_content_position": {
"options__1": {
Expand Down Expand Up @@ -1054,9 +1057,12 @@
"label": "작게"
},
"options__3": {
"label": "크게"
"label": "보통"
},
"label": "이미지 높이"
"label": "이미지 높이",
"options__4": {
"label": "크게"
}
},
"layout": {
"options__1": {
Expand Down
Loading