Animate featured product and product info #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @metamoni! Just a few UX notes on this one. Let's adjust so that:
|
metamoni
force-pushed
the
animate-featured-product
branch
from
f1b3aef to
bf15f4b
Compare
metamoni
force-pushed
the
animate-featured-product
branch
from
bf15f4b to
da3ed3d
Compare
kjellr
previously approved these changes
Mar 16, 2023
metamoni
force-pushed
the
animate-featured-collection
branch
2 times, most recently
from
4112234 to
9ed5af0
Compare
metamoni
force-pushed
the
animate-featured-collection
branch
from
e755352 to
5fc448a
Compare
melissaperreault
requested changes
Mar 18, 2023
There was a problem hiding this comment.
Thank you Monica! I found 2 little things:
- When the setting
Enable sticky content on desktopis unchecked, the behavior is different, the content doesn't slide in anymore. (Video reference) - When navigating a product with 3D models, the delay until the media displays is longer than usual. (Video reference)
metamoni
force-pushed
the
animate-featured-collection
branch
12 times, most recently
from
87853d2 to
1e5eaae
Compare
metamoni
force-pushed
the
animate-featured-collection
branch
2 times, most recently
from
b4c2dc1 to
f832fc8
Compare
kjellr
approved these changes
Apr 11, 2023
metamoni
force-pushed
the
animate-featured-product
branch
from
5a65315 to
5fd1819
Compare
metamoni
force-pushed
the
animate-featured-product
branch
from
5fd1819 to
0a3727d
Compare
|
Just noting that this branch will have a known bug when merged in (video below). A fix is being worked on by @ludoboludo in this PR. bug.mp4 |
metamoni
force-pushed
the
animate-featured-product
branch
from
0a3727d to
cc0d5cc
Compare
stufreen
approved these changes
Apr 17, 2023
metamoni
force-pushed
the
animate-featured-product
branch
from
cc0d5cc to
5626ddb
Compare
LucasLacerdaUX
approved these changes
Apr 18, 2023
* add animation to Image banner and Image with text
Co-authored-by: Lucas Lacerda <37168033+LucasLacerdaUX@users.noreply.github.com>
metamoni
force-pushed
the
animate-featured-product
branch
from
5626ddb to
268db75
Compare
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
animate Featured Product and Product Information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Adds fade in on scroll to the following areas
Why are these changes introduced?
Fixes #2390
What approach did you take?
Replicated animations from the original prototype
Visual impact on existing themes
Will animate product info and featured product on scroll, when
Reveal sections on scrollis enabledfeatured-product-prod-info.mp4
Testing steps/scenarios
Reveal sections on scrollunderAnimationsin Theme settingsDemo links
Checklist