Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Header] fix shadow on locale selector in the menu drawer #2465

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

ludoboludo
Copy link
Contributor

Fixes an issue discovered while testing our theme for the release. Specifically Crave.

A shadow is still shown on the locale selectors when it shouldn't:

@ludoboludo ludoboludo changed the base branch from main to 9.0.0-release-branch March 23, 2023 16:27
@ludoboludo ludoboludo merged commit a941af8 into 9.0.0-release-branch Mar 23, 2023
@ludoboludo ludoboludo deleted the shadow-fix-locales branch March 23, 2023 17:27
ludoboludo added a commit that referenced this pull request Mar 24, 2023
* change version number

* Fix locales shadow in menu drawer (#2465)

* add release notes
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* change version number

* Fix locales shadow in menu drawer (Shopify#2465)

* add release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants