Fix improper image sizes in the collage section #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenekasimov
force-pushed
the
fix-image-size-collage
branch
from
4d3c2bd to
5133ade
Compare
ludoboludo
reviewed
Mar 30, 2023
ludoboludo
reviewed
Mar 31, 2023
Comment on lines
+51
to
+52
| assign grid_space_desktop = settings.spacing_grid_horizontal | divided_by: 2 | append: 'px' | ||
| assign grid_space_mobile = settings.spacing_grid_horizontal | divided_by: 4 | append: 'px' |
There was a problem hiding this comment.
One thing I'm wondering about. Why does it need to be divided by 2 and 4 🤔 Since the spacing is applied once
There was a problem hiding this comment.
Because let's say there is a 40px gap, this 40px approximately equally split between 2 images. Since we are trying to calculate an image size we need to account it partially. If I account 40px for the first image only then the second image size will be calculated wrong.
ludoboludo
approved these changes
Mar 31, 2023
metamoni
approved these changes
Apr 3, 2023
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Apr 5, 2023
* shopify/main: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480)
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Apr 12, 2023
* next: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480) Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Add logic for collage image sizes * Add more logic and refactor. * Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR improves the way images are loaded in the collage section. It accounts for many factors that image sizes depend on.
Why are these changes introduced?
Fixes #2354.
What approach did you take?
I rewrote the logic of how we create our srcset and choose sizes. Now it accounts for the page width, desktop/tablet/mobile layouts, number of columns, size of the image in collage and paddings.
Other considerations
Decision log
Visual impact on existing themes
No visual impact
Testing steps/scenarios
Demo links
Checklist