Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate search template #2534

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Animate search template #2534

merged 2 commits into from
Apr 19, 2023

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Apr 14, 2023

PR Summary:

This adds animation to the search template.

Why are these changes introduced?

Part of #2381.

What approach did you take?

This follows the same general template animation strategy set forth in #2381 (comment):

  • The page heading (and associated top-of-the-page content) fades in.
  • The rest of the template content slides in on scroll. Search results slide in sequentially.

Visual impact on existing themes

When "Reveal sections on scroll" is enabled, this will animate elements on the search results page template.

⚠️ Please note, the filters will not animate in. #2533 currently handles the animation of filters, so this will happen automatically when that one is merged in.

search.mp4

Testing steps/scenarios

  • Ensure that "Reveal sections on scroll" is active in Theme Settings > Animation.
  • Visit a search results page.
  • Ensure the header and search field fade in on load.
  • Ensure the search results slide in sequentially on scroll.

Demo links

Checklist

@@ -242,7 +245,7 @@
lazy_load: lazy_load
%}
{%- when 'page' -%}
<div class="article-card-wrapper card-wrapper underline-links-hover">
<div class="article-card-wrapper card-wrapper underline-links-hover{% if settings.animations_reveal_on_scroll %} scroll-trigger animate--slide-in{% endif %}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this instance since we already have the class applied to the parent li 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think I got confused there. Removed in ea377de.

@ludoboludo ludoboludo merged commit d902375 into main Apr 19, 2023
@ludoboludo ludoboludo deleted the animate-search-template branch April 19, 2023 18:19
@melissaperreault
Copy link
Contributor

I was looking around to catch up, is it expected to not have the filter component not animate?

@kjellr
Copy link
Contributor Author

kjellr commented Apr 26, 2023

@melissaperreault Yep! The filter component is a shared one that's handled by #2533. Once that's merged in, it will animate in search results too.

phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* Animate search template.

* Remove unnecessary class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants