Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use errors key preferentially over description for gift card JSON errors #2554

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

antiBaconMachine
Copy link
Contributor

PR Summary:

Small change that reads errors from an errors property instead of reusing the description field as before.

Why are these changes introduced?

Just trying to keep things clear and concise for other theme developers. Description should in future be for semantic descriptions not structured error messages.

What approach did you take?

For now the backend will send identical payloads in both errors and description keys so this is non breaking. Eventually we'll look to deprecate description for this use case.

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

Testing steps/scenarios

  • Step 1

Demo links

Checklist

@antiBaconMachine antiBaconMachine merged commit a142da6 into main Apr 24, 2023
@antiBaconMachine antiBaconMachine deleted the antibaconmachine/change-error-key branch April 24, 2023 15:11
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants