Use errors
key preferentially over description
for gift card JSON errors
#2554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Small change that reads errors from an
errors
property instead of reusing the description field as before.Why are these changes introduced?
Just trying to keep things clear and concise for other theme developers. Description should in future be for semantic descriptions not structured error messages.
What approach did you take?
For now the backend will send identical payloads in both errors and description keys so this is non breaking. Eventually we'll look to deprecate description for this use case.
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist