[Announcement bar] Change the slider width to 60% #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenekasimov
force-pushed
the
change-announcement-bar-slider-size
branch
from
a1a89ae to
ccc8f76
Compare
assets/base.css
Outdated
Comment on lines
2321
to
2322
| .announcement-bar-slider { | ||
| width: 60% |
There was a problem hiding this comment.
I think this fixed the issue on mobile but now on large screen it doesn't look at 60% visually
There was a problem hiding this comment.
@melissaperreault I'm confused about the screenshot. The portion you highlighted looks like 40% to me, rather than 60%. What @eugenekasimov did looks right to me 🤔
There was a problem hiding this comment.
👀 You are so right! Sorry for the confusion, I guess it was my Friday brain! 😆
There was a problem hiding this comment.
@melissaperreault So, everything looks okay 😅 ?
metamoni
approved these changes
May 1, 2023
kmeleta
reviewed
May 1, 2023
kmeleta
approved these changes
May 1, 2023
Co-authored-by: Ken Meleta <30790058+kmeleta@users.noreply.github.com>
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Change the slider width to 60% * Change the slider width to 60% * Add missing ';' Co-authored-by: Ken Meleta <30790058+kmeleta@users.noreply.github.com> --------- Co-authored-by: Ken Meleta <30790058+kmeleta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR changes the announcement bar slider with to 60%.
Why are these changes introduced?
This change was a part of another PR, however due to lack of time we won't be able to review that PR before the upcoming release. We want to reduce the width to avoid that too prominent animation that we currently have. We'll add a more elegant animation to the announcement bar slider as a next step.
What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist