Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple announcement bars in Header group #2619

Merged
merged 2 commits into from
May 12, 2023
Merged

Allow multiple announcement bars in Header group #2619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5a0985
allow multiple announcement bars, only in header
metamoni May 10, 2023
cb16973
Update 4 translation files
translation-platform[bot] May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions locales/en.default.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@
}
}
}
},
"presets": {
"name": "Announcement bar"
}
},
"apps": {
Expand Down
3 changes: 3 additions & 0 deletions locales/es.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@
"change_slides_speed": {
"label": "Cambiar de diapositiva cada"
}
},
"presets": {
"name": "Barra de anuncios"
}
},
"collage": {
Expand Down
3 changes: 3 additions & 0 deletions locales/ko.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@
"change_slides_speed": {
"label": "슬라이드 변경 간격"
}
},
"presets": {
"name": "공지 표시줄"
}
},
"collage": {
Expand Down
3 changes: 3 additions & 0 deletions locales/nb.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@
"change_slides_speed": {
"label": "Endre lysbilde hvert"
}
},
"presets": {
"name": "Kunngjøringslinje"
}
},
"collage": {
Expand Down
3 changes: 3 additions & 0 deletions locales/tr.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@
"change_slides_speed": {
"label": "Slaytları şu zaman aralığında değiştir:"
}
},
"presets": {
"name": "Duyuru çubuğu"
}
},
"collage": {
Expand Down
20 changes: 13 additions & 7 deletions sections/announcement-bar.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@
"name": "t:sections.announcement-bar.name",
"max_blocks": 12,
"class": "announcement-bar-section",
"enabled_on": {
"groups": ["header"]
},
"settings": [
{
"type": "color_scheme",
Expand Down Expand Up @@ -146,12 +149,15 @@
]
}
],
"default": {
"blocks": [
{
"type": "announcement"
}
]
}
"presets": [
{
"name": "t:sections.announcement-bar.presets.name",
"blocks": [
{
"type": "announcement"
}
]
}
]
Copy link
Contributor

@ludoboludo ludoboludo May 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if you are able to replicate but this new ability made me uncover some lag and jumps on the page as I browse the navigation on smaller screen. Video reference (to watch at 0:25)

I think this is due to the fact that those are the first elements in the view of the page and they need a bit of JS to get everything setup. So there might be a bit of flash like you noticed. Something we could look into and potentially fix by moving some CSS around and making sure it's loaded as soon as possible to prevent what you saw. It might be easier to test by simulating a slow network

Copy link
Contributor Author

@metamoni metamoni May 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melissaperreault I'm struggling to replicate the behaviour in your video, where the font initially appears bigger, but I do see a slight jump. I have noticed it on main as well, though, so I don't think this issue was introduced by the stacked announcement bars. Here's a slow motion video of what I'm seeing on main.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks! We can open an issue to investigate further!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New issue created here: #2632

}
{% endschema %}