Made mobile drawer full width by default-header #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmeleta
approved these changes
May 15, 2023
|
Thanks Louisa, this looks good. Just want to confirm with @YoannJailin that desktop and "tablet" drawers should remain as they are (viewports 750px and wider). |
|
Hello! Thanks it looks great. 
|
…when l1,l2&l3 links were opened
YoannJailin
approved these changes
May 15, 2023
kmeleta
requested changes
May 15, 2023
…top and removed it for mobile version
assets/component-menu-drawer.css
Outdated
Comment on lines
74
to
77
| .no-js .menu-drawer { | ||
| height: auto; | ||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| .no-js .menu-drawer { | |
| height: auto; | |
| } | |
| .no-js .menu-drawer { | |
| height: auto; | |
| } |
There was a problem hiding this comment.
Thank you for catching that! I just removed it and pushed the changes
kmeleta
approved these changes
May 16, 2023
lougoncharenko
deleted the
louisa-header-make-mobile-drawer-full-width-by-default
branch
ludoboludo
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Made mobile drawer full width by default-header * removed the small vertical line border kept appearing on drawer menu when l1,l2&l3 links were opened * reverted code to include border for customization for tablet and desktop and removed it for mobile version * removed border in mobile and added it in tablet version using media queries * removed white space per suggestion
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Jun 14, 2023
* shopify/main: (59 commits) [Announcement bar] Add social icons (Shopify#2497) Update theme version to match the pubic release (Shopify#2698) Add release/v10.0.0 branch fixes to main (Shopify#2693) fix default UI for dropdown and mega menu (Shopify#2644) Fix link formatting in Related Products heading (Shopify#2680) Update 2 translation files (Shopify#2637) Enable gift card recipient form by default on featured product section (Shopify#2666) Gift cards/enable recipient form by default (Shopify#2618) Add a Color Scheme setting for Menus-Header (Shopify#2622) Made mobile drawer full width by default-header (Shopify#2625) Allow multiple announcement bars in Header group (Shopify#2619) [Feat Product] Add rating styling sheet (Shopify#2620) Fix password page variables (Shopify#2607) Fix transform applied when it should not for sliders (Shopify#2606) Modify info string for gift card recipient checkbox (Shopify#2588) [3D lift animation] Raise hovered card above adjacent cards (Shopify#2589) Remove fallback color scheme info text (Shopify#2602) Fix CSS specifity issue to cancel animation for theme editor events (Shopify#2605) Remove settings daya for icon color (Shopify#2601) Follow ups for accessibility of announcements slider (Shopify#2580) ...
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Made mobile drawer full width by default-header * removed the small vertical line border kept appearing on drawer menu when l1,l2&l3 links were opened * reverted code to include border for customization for tablet and desktop and removed it for mobile version * removed border in mobile and added it in tablet version using media queries * removed white space per suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Mobile drawer is full width by default
Why are these changes introduced?
Fixes #2563
What approach did you take?
I changed the width of the menu-drawer to be 100% by default.
Visual impact on existing themes
Not Applicable
Testing steps/scenarios
Demo links
Checklist