Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2654

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Update README.md #2654

merged 1 commit into from
Jul 10, 2023

Conversation

Stephanie-Chou
Copy link
Contributor

PR Summary:

add the following line under the 'getting started' heading in the dawn readme.
Please note that the main branch may include code for features not yet released. The "stable" version of Dawn is available in the theme store.

Why are these changes introduced?

responds to feedback on readme clarity. Ssome devs had confusion on which version of dawn to use for client updates.

Fixes #2628

What approach did you take?

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

Testing steps/scenarios

checked readme Preview

Demo links

Checklist

responds to feedback on readme clarity in #2628

some devs had confusion on which version of dawn to use for client updates.
Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stephanie! I think that covers it and I agree with where you put it. Couple minor adjustments to consider but I don't feel strongly at all.

We recommend using Dawn as a starting point for theme development. [Learn more on Shopify.dev](https://shopify.dev/themes/getting-started/create).

> If you're building a theme for the Shopify Theme Store, then you can use Dawn as a starting point. However, the theme that you submit needs to be [substantively different from Dawn](https://shopify.dev/themes/store/requirements#uniqueness) so that it provides added value for merchants. Learn about the [ways that you can use Dawn](https://shopify.dev/themes/tools/dawn#ways-to-use-dawn).

Please note that the main branch may include code for features not yet released. The "stable" version of Dawn is available in the theme store.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it stand out more if we did this?

Suggested change
Please note that the main branch may include code for features not yet released. The "stable" version of Dawn is available in the theme store.
Note: The `main` branch may include code for features not yet released. The "stable" version of Dawn is available in the theme store.

@stephanie-shopify stephanie-shopify merged commit ca10591 into main Jul 10, 2023
@stephanie-shopify stephanie-shopify deleted the readme-update-branches branch July 10, 2023 19:19
lougoncharenko pushed a commit that referenced this pull request Jul 12, 2023
responds to feedback on readme clarity in #2628

some devs had confusion on which version of dawn to use for client updates.
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
responds to feedback on readme clarity in Shopify#2628

some devs had confusion on which version of dawn to use for client updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation failed: Invalid schema: setting color_scheme type is invalid
4 participants