-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aligned share-button and view-details #2724
Merged
lougoncharenko
merged 3 commits into
main
from
fix-featured-product-alignment-between-share-button-and-view-details
Jun 26, 2023
Merged
aligned share-button and view-details #2724
lougoncharenko
merged 3 commits into
main
from
fix-featured-product-alignment-between-share-button-and-view-details
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ludoboludo
reviewed
Jun 21, 2023
ludoboludo
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me 👍
YoannJailin
approved these changes
Jun 22, 2023
kmeleta
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simple fix! Couple nitpicks we might as well address then we're good to go.
kmeleta
approved these changes
Jun 22, 2023
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* aligned share-button and view-details * added a temporary fix for the alignment * removed white space and changed font size to rem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Share button and View full details link are now aligned on the featured product section in both mobile, tablet and desktop.
Why are these changes introduced?
Fixes #2289
What approach did you take?
-Created a container for both the Share button and View full details link. Added display flex an justify content: center to align both.
Other considerations
-The easiest way was to put them in a container and apply css.
Visual impact on existing themes
This will look visually better as both buttons will now be aligned
Testing steps/scenarios
Demo links
Checklist