Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aligned share-button and view-details #2724

Conversation

lougoncharenko
Copy link
Contributor

PR Summary:

Share button and View full details link are now aligned on the featured product section in both mobile, tablet and desktop.

Why are these changes introduced?

Fixes #2289

What approach did you take?

-Created a container for both the Share button and View full details link. Added display flex an justify content: center to align both.

Other considerations

-The easiest way was to put them in a container and apply css.

  • A more challenging approach would be to make view full details link a block that can be added to featured product since it was a separate entity (not a local block). That way users have the flexibility to drag and drop the link where ever they like (most likely this solution will be reserved for the flex section project)

Visual impact on existing themes

This will look visually better as both buttons will now be aligned

Testing steps/scenarios

  • Align when product is empty (placeholder image)
  • Align when product is selected (with image)
  • Align when product is selected (without any image)
  • Test with mobile, tablet and desktop
  • Test with color scheme
  • Test with adding additional local blocks

Demo links

Checklist

Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me 👍

Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix! Couple nitpicks we might as well address then we're good to go.

@lougoncharenko lougoncharenko requested a review from kmeleta June 22, 2023 18:31
@lougoncharenko lougoncharenko merged commit c2675c1 into main Jun 26, 2023
@lougoncharenko lougoncharenko deleted the fix-featured-product-alignment-between-share-button-and-view-details branch June 26, 2023 12:25
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* aligned share-button and view-details

* added a temporary fix for the alignment

* removed white space and changed font size to rem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Featured product] Alignment between share button and view details is off
4 participants