Updating custom liquid section #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoboludo
approved these changes
Jun 21, 2023
| "label": "Custom Liquid", | ||
| "info": "Add app snippets or other Liquid code to create advanced customizations." | ||
| "label": "Liquid Code", | ||
| "info": "Add app snippets or other code to create advanced customizations." |
There was a problem hiding this comment.
Looks good. I'm guessing the link coming up here isn't something we can edit in the theme but part of what we get 🤔
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
locales/en.default.schema.json
Outdated
| @@ -651,8 +651,8 @@ | |||
| "name": "Custom Liquid", | |||
| "settings": { | |||
| "custom_liquid": { | |||
| "label": "Custom Liquid", | |||
| "info": "Add app snippets or other Liquid code to create advanced customizations." | |||
| "label": "Liquid Code", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Liquid Codefor keysections.custom-liquid.settings.custom_liquid.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
|
Looks good to me, thanks! edit: sorry, one nitpicky edit: |
kmeleta
approved these changes
Jul 5, 2023
10 tasks
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* changed main-product and featured product to reference custom liquid translations * removed Learn more link from paragraph-waiting on top link to be removed * lowercased c in code * Update 18 translation files * Update 2 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Custom Liquid Section is updated based off of feedback from the recent no-code friction log.
Why are these changes introduced?
Fixes #2645.
What approach did you take?
I changed the wording in the label and info for custom liquid to make the new recommendations.
Visual impact on existing themes
The new changes will have no applicable changes to merchants current theme versions.
Testing steps/scenarios
Demo links
Checklist