login is aligned with nav links when language & country unselected #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
kmeleta
reviewed
Jun 27, 2023
kmeleta
approved these changes
Jun 27, 2023
|
Hey! *Nit-pick Curious why the padding is 30px when lang/currency is present, but 20px + 10px margin without it? |
ludoboludo
reviewed
Jun 28, 2023
There was a problem hiding this comment.
Looking good. I'm questioning the values we're using though. As we have both 2rem 3rem and 3rem. I think we could maybe be consistent.
And then I wanted to mention that there is one more test scenario you can check (I did and it looked good 👍) is when you disable account on the store.
It's not controlled at the theme level but in the admin settings. Here is a little video on how you'd go about disabling/enabling accounts on the storefront.
kmeleta
approved these changes
Jun 29, 2023
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
…hopify#2743) * login is now aligned with nav links when language and country selectors are unselected * fixed alignment on account & social icons * applied feedback * changed utlitility links to be 3rem vs 2rem +1rem from margin-left padding * implemented hanges from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
When mobile drawer is login only, the login link is aligned with the nav links.
Why are these changes introduced?
Fixes #2671 .
What approach did you take?
I used a css class to apply the margin-left when the utility links were missing the localization form but had the account.
Other considerations
N/A
Visual impact on existing themes
If merchants choose to unselect the country and language selector, the account login button will be aligned on the mobile version.
Testing steps/scenarios
Demo links
Checklist