fixed bug that was causing extra spacing in footer #2745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Footer will not have extra space when unchecking the "Show email signup" setting in the footer.
Why are these changes introduced?
Fixes #2691 .
What approach did you take?
Added
and has_social_icons == true
in the section block to check if social media icons are present.Other considerations
N/A
Visual impact on existing themes
If a merchant chooses to add an email sign up section and remove the default email sign up, there will no longer be a extra space between both section.
Testing steps/scenarios
Demo links
Checklist