added preset to apply outline button in image-with-text #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
approved these changes
Jun 28, 2023
ludoboludo
approved these changes
Jun 28, 2023
lougoncharenko
deleted the
add-a-setting-to-enable-the-secondary-button-style-in-image-with-textliquid
branch
lougoncharenko
added a commit
that referenced
this pull request
Jul 12, 2023
* added preset to apply outline button in image-with-text * Update 10 translation files * Update 10 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* added preset to apply outline button in image-with-text * Update 10 translation files * Update 10 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Image with text section has a checkbox to apply outline button style on button
Why are these changes introduced?
Fixes #2707.
What approach did you take?
I added a preset in the image with text liquid file.
The preset is a checkbox that when checked, applies the button_style_secondary id on the button.
Other considerations
Maybe from a Ux perspective, we can later on add more button styles and change the preset from a checkbox to a dropdown
Visual impact on existing themes
Merchants will have more flexibility on changing the way their button looks on image with text.
Testing steps/scenarios
Demo links
Checklist