-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shadow opacity to dropdowns and pop-ups #2780
Merged
melissaperreault
merged 2 commits into
main
from
update-dropdowns-popups-shadow-opacity
Jul 10, 2023
Merged
Add shadow opacity to dropdowns and pop-ups #2780
melissaperreault
merged 2 commits into
main
from
update-dropdowns-popups-shadow-opacity
Jul 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoboludo
approved these changes
Jul 6, 2023
kjellr
reviewed
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change from 10 to 5
kjellr
approved these changes
Jul 10, 2023
stephanie-shopify
approved these changes
Jul 10, 2023
kmeleta
approved these changes
Jul 10, 2023
lougoncharenko
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Add shadow opacity to dropdowns and pop-ups * Change from 10 to 5 Change from 10 to 5
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Add shadow opacity to dropdowns and pop-ups * Change from 10 to 5 Change from 10 to 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Increase the elevation of dropdowns and pop-ups components by default.
Why are these changes introduced?
Improves the elevation of this type of component in general for Dawn only. Feels aligned to add some depth considering what we introduced on cards hover with larger shadows. We saw this opportunity because of the UI details for the new Variant list section.
Visual impact on existing themes
Navigation dropdowns, pop-up modals, and cart pop-ups will receive a soft shadow of 5%.
Testing steps/scenarios
Demo links
Checklist