Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow opacity to dropdowns and pop-ups #2780

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

melissaperreault
Copy link
Contributor

@melissaperreault melissaperreault commented Jul 6, 2023

PR Summary:

Increase the elevation of dropdowns and pop-ups components by default.

Why are these changes introduced?

Improves the elevation of this type of component in general for Dawn only. Feels aligned to add some depth considering what we introduced on cards hover with larger shadows. We saw this opportunity because of the UI details for the new Variant list section.

Visual impact on existing themes

Navigation dropdowns, pop-up modals, and cart pop-ups will receive a soft shadow of 5%.

Testing steps/scenarios

  • Navigate the store and notice the nav dropdown
  • Open the search dropdown
  • Add a product to cart
  • Validate the Dropdowns and pop-ups shadow value in Theme settings

Demo links

Checklist

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change — I think it makes sense to add a small amount of depth here.

Can we make this 5% instead of 10% though? It's minor, but I feel the more subtle shadow matches the light aesthetic of the theme a little more closely:

10% 5%
Screenshot 2023-07-10 at 8 25 32 AM Screenshot 2023-07-10 at 8 25 20 AM

Change from 10 to 5
@melissaperreault melissaperreault merged commit 6fd1fc8 into main Jul 10, 2023
@melissaperreault melissaperreault deleted the update-dropdowns-popups-shadow-opacity branch July 10, 2023 21:17
lougoncharenko pushed a commit that referenced this pull request Jul 12, 2023
* Add shadow opacity to dropdowns and pop-ups

* Change from 10 to 5

Change from 10 to 5
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* Add shadow opacity to dropdowns and pop-ups

* Change from 10 to 5

Change from 10 to 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants