Fix an error #2903
Merged
Fix an error #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiamatulis
approved these changes
Jul 21, 2023
| @@ -284,9 +284,10 @@ class QuickOrderList extends HTMLElement { | |||
| } else { | |||
| this.updateMessage(-parseInt(quantityElement.dataset.cartQuantity)) | |||
| } | |||
| }).catch(() => { | |||
| }).catch((error) => { | |||
There was a problem hiding this comment.
Let's remove the console log
There was a problem hiding this comment.
Kai suggested to keep it, so next time we will know right away what’s causing the error.
There was a problem hiding this comment.
We dont really add this in other places 🤔 Shouldnt we just add it if we are debugging?
There was a problem hiding this comment.
We can keep the logging. We actually log errors to the console in a few places in the theme (search for console.error).
In normal circumstances, we should never see any errors logged, but when making changes it's probably better to see an error in the console and catch it early rather than missing a suppressed error.
There was a problem hiding this comment.
Ahhh I was searching for console.log . Thank you!
KaichenWang
approved these changes
Jul 24, 2023
| @@ -284,9 +284,10 @@ class QuickOrderList extends HTMLElement { | |||
| } else { | |||
| this.updateMessage(-parseInt(quantityElement.dataset.cartQuantity)) | |||
| } | |||
| }).catch(() => { | |||
| }).catch((error) => { | |||
There was a problem hiding this comment.
We can keep the logging. We actually log errors to the console in a few places in the theme (search for console.error).
In normal circumstances, we should never see any errors logged, but when making changes it's probably better to see an error in the console and catch it early rather than missing a suppressed error.
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
KaichenWang
pushed a commit
that referenced
this pull request
Jul 26, 2023
sjflaher
added a commit
that referenced
this pull request
Jul 27, 2023
* Price per item, Popover and global style bugs (#2851) * Fix cart submission on Quick Order List (#2868) * replace translation string to have the translation visible (#2869) * B2B compare at price with price range (#2858) * Add sale badge and price-range for volume-pricing * Add compare_at price to PDP and Feat Prod. * Change opacity to 100% for price per item. * Update the logic * Hide price per item for unavailable variants. * Remove margin for dl. * Refactoring * Correct a mistake in liquid. * Change the JS logic back for updating price per item * Add compare at to prod card. Add style to compare at * Add missing shadow styles to inputs in Quick Order List (#2879) * Fix cart drawer for variant list and tablet spacing (#2880) * Replace generic section name with section ID. (#2884) * Fix error misalignment for Quick order list (#2887) * Fix error misalignment * Reduce top space. Address feedback. * Fix hardcoded info color (#2893) * Fix an error (#2903) * Fix social list styles loading (#2900) * v11.0.0 version bump and release notes (#2906) * Update quantity-popover.css Add new line at end of file * Revert "v11.0.0 version bump and release notes (#2906)" (#2915) This reverts commit 13dec2a. * v11.0.0 version bump and release notes (#2916) --------- Co-authored-by: Sofia Matulis <sofiamatulis@users.noreply.github.com> Co-authored-by: melissaperreault <melissa.perreault@shopify.com> Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com> Co-authored-by: Ken Meleta <30790058+kmeleta@users.noreply.github.com> Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
TimmersThomas
added a commit
to TimmersThomas/shopify-template-houseofchocolate
that referenced
this pull request
Aug 13, 2023
* upstream/main: (205 commits) Fix for small screens with large fonts don't fit all content (Shopify#2946) Adjust quantity rules margin (Shopify#2948) Update Social media settings defaults to remove Shopify links (Shopify#2830) added json to barcode to pass gtin as a json string (Shopify#2804) Fixed extra margin spacing in collage section when header is empty (Shopify#2770) Track state of mouseenter event (Shopify#2934) Fix misalignment of total items in quick order list (Shopify#2923) Hide vol pricing and qty rules when variant is unavailable (Shopify#2889) Fix font family for quick order list (Shopify#2888) v11.0.0 version bump and release notes (Shopify#2916) Revert "v11.0.0 version bump and release notes (Shopify#2906)" (Shopify#2915) Update quantity-popover.css v11.0.0 version bump and release notes (Shopify#2906) Fix social list styles loading (Shopify#2900) Fix an error (Shopify#2903) Fix hardcoded info color (Shopify#2893) Fix error misalignment for Quick order list (Shopify#2887) Replace generic section name with section ID. (Shopify#2884) Fix cart drawer for variant list and tablet spacing (Shopify#2880) Add missing shadow styles to inputs in Quick Order List (Shopify#2879) ...
SmolSoftBoi
pushed a commit
to m-k-enterprises/dawn
that referenced
this pull request
Feb 18, 2024
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR fixes an error that you could see by changing qty in quick order list and the cart was set not to drawer.
Why are these changes introduced?
Fixes #2902 .
What approach did you take?
Other considerations
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist