Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product form] Update the disabled attribute approach to work with no-js #3054

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ludoboludo
Copy link
Contributor

PR Summary:

Looking into a different approach in which we remove the disabled attribute faster without compromising no-js.

Why are these changes introduced?

Related to this PR that recently shipped

What approach did you take?

Remove the attribute via inline JS so it's doing it faster than waiting for product-form.js to load.

Other considerations

Different position to place the JS / Remove the repetitive removal of the disabled attribute in the product-form custom element JS.

Visual impact on existing themes

Testing steps/scenarios

  • Go to the store preview,
  • Open the inspect tool and go to the network tab, throttle the connection to a slow 3G one
  • Reload the home page and try to click on Add to cart as soon as you see the button show up for the feat. collection section

Demo links

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant