-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Facets] update visual representation of facets operators #3061
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -223,11 +223,34 @@ | |
transition: text-decoration var(--duration-short) ease; | ||
} | ||
|
||
.facets__summary:hover span { | ||
.facets__summary:hover .facets__summary-label { | ||
text-decoration: underline; | ||
text-underline-offset: 0.3rem; | ||
} | ||
|
||
.facets__and-helptext { | ||
color: rgba(var(--color-foreground), 0.5); | ||
font-size: calc(var(--font-heading-scale) * 1.2rem); | ||
line-height: calc(var(--font-heading-scale) * 1.2rem); | ||
} | ||
|
||
@media only screen and (min-width: 750px) { | ||
.facets__and-helptext { | ||
font-size: calc(var(--font-heading-scale) * 1.3rem); | ||
line-height: calc(var(--font-heading-scale) * 1.3rem); | ||
} | ||
} | ||
|
||
.facets__disclosure .facets__and-helptext, | ||
.facets__disclosure-vertical .facets__and-helptext { | ||
display: none; | ||
} | ||
|
||
.facets__disclosure[open] .facets__and-helptext, | ||
.facets__disclosure-vertical[open] .facets__and-helptext { | ||
display: block; | ||
} | ||
|
||
.disclosure-has-popup[open] > .facets__summary::before { | ||
z-index: 2; | ||
} | ||
|
@@ -268,6 +291,10 @@ | |
z-index: 1; | ||
} | ||
|
||
.facets__header facet-remove { | ||
align-self: center; | ||
} | ||
|
||
.facets__list { | ||
padding: 0.5rem 2rem; | ||
} | ||
|
@@ -768,14 +795,20 @@ details.menu-opening .mobile-facets__close svg { | |
.mobile-facets__close-button { | ||
align-items: center; | ||
background-color: transparent; | ||
display: flex; | ||
font-size: 1.4rem; | ||
font: inherit; | ||
letter-spacing: inherit; | ||
margin-top: 1.5rem; | ||
padding: 1.2rem 2.6rem; | ||
text-decoration: none; | ||
width: calc(100% - 5.2rem); | ||
|
||
display: grid; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clever |
||
grid-template-columns: min-content 1fr; | ||
text-align: start; | ||
} | ||
|
||
.mobile-facets__close-button > .facets__and-helptext { | ||
grid-column-start: 2; | ||
} | ||
|
||
.no-js .mobile-facets__close-button { | ||
|
@@ -830,8 +863,7 @@ details.menu-opening .mobile-facets__close svg { | |
margin-left: auto; | ||
} | ||
|
||
.mobile-facets__summary > div, | ||
.facets__summary > div { | ||
.mobile-facets__summary > div { | ||
display: flex; | ||
align-items: center; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -179,6 +179,7 @@ | |
"label": "Media gallery" | ||
}, | ||
"facets": { | ||
"filter_and_operator_subtitle": "Match all", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Localization quality issue found The following issues may affect the quality of localized translations if they are not addressed:
Please look out for other instances of this issue in your PR and fix them as well if possible. Questions about these messages? Hop in the #help-localization Slack channel. |
||
"apply": "Apply", | ||
"clear": "Clear", | ||
"clear_all": "Remove all", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth pointing out that all the other media query changes are grouped into a single media query at the bottom of this css file. For what it's worth, I prefer colocation which you've done here, but it is different than the pattern established. Again, I like what you've done here, but wanted to point it out and let you decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer colocation by far (and there are 2 media queries at the beguinning of the file :P which is why I allowed myself to do this)