Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap :not(list) with :not():not() #311

Merged
merged 1 commit into from
Sep 2, 2021
Merged

swap :not(list) with :not():not() #311

merged 1 commit into from
Sep 2, 2021

Conversation

ekwoka
Copy link
Contributor

@ekwoka ekwoka commented Aug 4, 2021

Lists inside of :not() selectors are not supported in Samsung Browser, but chaining :not():not() is support in all major browsers

Why are these changes introduced?

Fixes #303

What approach did you take?

Extracted multiple classes inside list based :not() into separate chained :not() selector.

Checklist

@ekwoka
swap :not(list) with :not():not()
2115403 
Lists inside of :not() selectors are not supported in Samsung Browser, but chaining :not():not() is support in all major browsers
@tyleralsbury
Copy link
Contributor

Thanks for your contribution. I've added this to our list of PRs to review.

@kmeleta kmeleta self-requested a review September 1, 2021 15:33
@kmeleta kmeleta self-assigned this Sep 1, 2021
kmeleta
kmeleta approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great find. It does appear the lack of support for a list argument in :not() is at fault for the issues we're seeing in Samsung Internet.

ludoboludo
ludoboludo approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! Thanks for the fix :) 🎉

@ludoboludo ludoboludo merged commit 5fcf79f into Shopify:main Sep 2, 2021
@kmeleta kmeleta linked an issue Sep 2, 2021 that may be closed by this pull request
Samsung Internet: Grey box on Product Pages #508
Closed
@kmeleta kmeleta mentioned this pull request Sep 2, 2021
Closed
@tyleralsbury tyleralsbury mentioned this pull request Sep 10, 2021
Closed
@martinamarien martinamarien mentioned this pull request Sep 13, 2021
Merged
@ludoboludo ludoboludo mentioned this pull request Oct 4, 2021
Closed
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
@ekwoka
swap :not(list) with :not():not() (Shopify#311)
05ca657 
Lists inside of :not() selectors are not supported in Samsung Browser, but chaining :not():not() is support in all major browsers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoboludo ludoboludo ludoboludo approved these changes

@kmeleta kmeleta Awaiting requested review from kmeleta

Assignees

@kmeleta kmeleta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Samsung Internet: Grey box on Product Pages Image space bugged on Samsung Browser and Edge for Android
4 participants
@ekwoka @tyleralsbury @ludoboludo @kmeleta