Fix featured collection slider margins #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmeleta
changed the title
kmeleta
commented
Aug 16, 2021
| @@ -17,7 +17,7 @@ | |||
| endif | |||
| -%} | |||
| <div class="collection page-width{% if section.settings.swipe_on_mobile == true and section.settings.collection.all_products_count > 2 and section.settings.products_to_show > 2 %} page-width-desktop{% endif %}"> | |||
| <div class="{% if section.settings.show_view_all and section.settings.swipe_on_mobile %}title-wrapper-with-link{% endif %}{% if section.settings.title == blank %} title-wrapper-with-link--no-heading{% endif %}{% if section.settings.collection.all_products_count > 2 and section.settings.swipe_on_mobile and section.settings.products_to_show > 2 %} title-wrapper--self-padded-tablet-down{% endif %}"> | |||
There was a problem hiding this comment.
This is unrelated to the product-grid issue, but fixes inconsistent spacing below the title in this section.
|
@tauthomas01 you should take a look at this with your product-grid context. Interested if you see a better way to resolve this. |
ludoboludo
approved these changes
Aug 17, 2021
tauthomas01
approved these changes
Aug 17, 2021
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #379
What approach did you take?
The product grid changes introduced in #176 applied some negative vertical margins that don't play nice with the absolutely positioned slider buttons below the slides/grid items, specifically in the featured collection section which is using the product grid (other slider sections don't appear to be affected).
The simplest fix seems to be declaring a default margin-bottom (of zero) on the slider class which will take priority over the default product grid margins. Slider slides (grid items) already set their own padding/margins in this way.
Other considerations
Another option is to just not apply the
product-gridclass at specific breakpoints when the slider setting is enabled, but we'd probably have to extend the product grid component to offer breakpoint exclusive classes (such asproduct-grid--desktop). I'm not sure this is necessary, but it's an option.Demo links
Checklist