Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky header Safari issue #466

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Sticky header Safari issue #466

merged 1 commit into from
Aug 24, 2021

Conversation

ludoboludo
Copy link
Contributor

Why are these changes introduced?

Fixes #321
Fixes #88

What approach did you take?

Removed the CSS property will-change: transform;

Other considerations

Demo links

Checklist

@kmeleta kmeleta self-requested a review August 23, 2021 22:05
Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to resolve the issue in safari 14.1 👍 No issues noticed in other browsers.

@ludoboludo ludoboludo merged commit 8195dc6 into main Aug 24, 2021
@ludoboludo ludoboludo deleted the sticky-header-safari-issue branch August 24, 2021 14:00
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants