SEO changes #506
SEO changes #506
Conversation
| @@ -4,7 +4,7 @@ | |||
| "theme_name": "Dawn", | |||
| "theme_version": "1.1.0", | |||
| "theme_author": "Shopify", | |||
| "theme_documentation_url": "https://shopify.dev/themes/tools/dawn", | |||
| "theme_documentation_url": "https://help.shopify.com/manual/online-store/themes/os20/themes-by-shopify/dawn", | |||
There was a problem hiding this comment.
The link does not seem to work. Is it expected that it will be deployed in the future?
There was a problem hiding this comment.
Yes! Sorry I should have added context for this. It's going to made available when the theme is launched.
As for the tags, it's usually needed when filtering used with tags assigned in the admin. We do filtering a different way now but it might still be useful in case anything else leverages it ? (apps, etc). You can add tags to products and also blog articles.
current_tags object
And right now to answer your question, I don't think we have a way to test it based on our theme and demo store setup.
There was a problem hiding this comment.
Looks good.
Tested tags by hardcoding the URL (e.g. https://os2-demo.myshopify.com/collections/all/handbag)
|
I see JSON LD is added for the: Articles I think that should be sufficient and covers most that other apps offer today, are there any plans to add additional schemas or build upon the one added? (not sure if it uses all possible fields etc. in the specs that might be useful)
I merged the change and will test with a schema tester for famme.no |
|
https://search.google.com/test/rich-results?id=_oY0RmI8j34peNJQ8ujxUA Missing a few fields that might be useful? I must admit I do not 100% know the need for those :) It might depend from brand to brand also I guess.
|
Why are these changes introduced?
Fixes #498
What approach did you take?
Added some logic to the
<title>to follow the recommendations we give on our help docs while this other issue is still open/discussed.Also added the
<script type="application/ld+json">where necessary.Also updated the link to the Dawn theme for
theme_documentation_urlOther considerations
I still need to test it out with Google's tool but since we keep a password on the theme I can't.
Demo links
Checklist