Password modal z-index #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaichenWang
previously approved these changes
Sep 7, 2021
ludoboludo
dismissed stale reviews from KaichenWang and tauthomas01
via
20f2259
ludoboludo
commented
Sep 7, 2021
| @@ -1708,7 +1708,7 @@ input[type='checkbox'] { | |||
| right: 0; | |||
| bottom: 0; | |||
| background: rgb(var(--color-background)); | |||
| z-index: 1; | |||
| z-index: 4; | |||
There was a problem hiding this comment.
this class is also used on the search modal from the header but from what I'm seeing it doesn't have any negative impact 🤔
|
Good find @KaichenWang. I also noticed that the styling was duplicated in cc: @tauthomas01 |
tauthomas01
approved these changes
Sep 8, 2021
KaichenWang
approved these changes
Sep 9, 2021
Merged
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Password modal z-index * update to 4 based on review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #557
What approach did you take?
Updated the
z-indexvalue of the.modal__contentto 3 instead of 1.I added all the sections available on the password page and test how it played with the modal. A
z-index: 3;seemed to suffice to resolve the issue.Other considerations
Demo links
Checklist
To test
In the theme editor, go to the password page and add sections, then open the modal by clicking on
Enter passwordand see if anything shows up on top of it.