Add scroll margin for login and recover pages #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmeleta
force-pushed
the
login-scroll-fix
branch
from
a431d0b to
855ef3e
Compare
kmeleta
commented
Sep 10, 2021
| @@ -338,7 +338,7 @@ | |||
| } | |||
|
|
|||
| #recover:target { | |||
| display: inline; | |||
| display: block; | |||
There was a problem hiding this comment.
This being inline seemed to prevent the scroll margin from working correctly in some browsers.
tauthomas01
approved these changes
Sep 10, 2021
Merged
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #358
What approach did you take?
The issue is caused by the no-js approach we're taking on this page. We're using the
:targetselector to hide/show the login and recover forms with anchor links/fragments. It is default browser behavior to snap the scroll to targeted element.The easiest solution is to use
scroll-margin-topproperty to offset where the browser snaps to.Other considerations
The latest versions of all browsers support scroll-margin-top, but recent versions safari have a bug that prevent the prop from applying to fragment targets like we need. See caniuse. Given that the experience isn't necessarily "broken" without this fix I think current support is acceptable versus implementing some javascript to handle it more consistently.
Demo links
Checklist