Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Password page] Add default blocks #82

Merged
merged 3 commits into from
Jun 30, 2021
Merged

[Password page] Add default blocks #82

merged 3 commits into from
Jun 30, 2021

Conversation

ludoboludo
Copy link
Contributor

@ludoboludo ludoboludo commented Jun 30, 2021

Why are these changes introduced?

Fixes #3 .

What approach did you take?

Added the block settings to the .json template. It was using some settings as if the section didn't have blocks.

Demo links

Checklist

@ludoboludo ludoboludo requested a review from bertiful June 30, 2021 14:34
@ludoboludo ludoboludo added Category: Bug Something isn't working Severity: 1 Urgent Severity labels Jun 30, 2021
@ludoboludo ludoboludo removed the Severity: 1 Urgent Severity label Jun 30, 2021
@sofiamatulis sofiamatulis self-assigned this Jun 30, 2021
Copy link
Contributor

@sofiamatulis sofiamatulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 💯

@bertiful bertiful merged commit 2cac0f7 into main Jun 30, 2021
@bertiful bertiful deleted the password-page-blocks branch June 30, 2021 17:39
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password template: Blocks missing in Email Sign Up section
5 participants