Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Title defaults to product, blog, article etc. title #96

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

tylerrowsell
Copy link
Member

Why are these changes introduced?

Currently the title on any page is just the shop name. It should default to the title of the product, blog, article, page etc.

What approach did you take?

Use page_title liquid attribute.
https://shopify.dev/api/liquid/objects#page_title

Other considerations

Demo links

Checklist

@tylerrowsell tylerrowsell changed the title page title Page Title Jul 5, 2021
@tylerrowsell tylerrowsell changed the title Page Title Page Title defaults to product, blog, article etc. title Jul 5, 2021
Copy link
Contributor

@bertiful bertiful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some overlap with #87 but good to merge this in as a first step. Thanks for fixing 👍🏻

@tyleralsbury tyleralsbury self-requested a review July 5, 2021 17:27
Copy link
Contributor

@tyleralsbury tyleralsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is self-explanatory. Tested and works as expected.

@bertiful bertiful merged commit 6ec8102 into main Jul 5, 2021
@bertiful bertiful deleted the page-title branch July 5, 2021 17:29
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants