Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden form field from require_input_autocomplete #232

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

afdev82
Copy link

@afdev82 afdev82 commented Jul 27, 2021

I don't think the hidden form field requires autocomplete.
The PR removes that from the list.

@rafaelfranca
Copy link
Member

Thank you for the pull request. Can you fix the broken test?

@michelle-gong
Copy link

Thanks Antonio!!

@afdev82
Copy link
Author

afdev82 commented Jul 28, 2021

I'll try at least ;)

Thank you for the pull request. Can you fix the broken test?

@afdev82 afdev82 force-pushed the remove_hidden_autocomplete branch from af8d344 to 62c9121 Compare July 28, 2021 08:23
@rafaelfranca rafaelfranca merged commit ce3fc33 into Shopify:main Jul 28, 2021
@shopify-shipit shopify-shipit bot temporarily deployed to production July 28, 2021 18:01 Inactive
@afdev82 afdev82 deleted the remove_hidden_autocomplete branch August 4, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants