Guard against missing config and surface config parsing errors #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
force-pushed
the
surface-syntax-errors
branch
from
961dadd
to
480d8a1
Compare
|
There's a linting error. While you're at it can you squash these commits together? Thanks. |
kevinsawicki
force-pushed
the
surface-syntax-errors
branch
from
480d8a1
to
42c73be
Compare
Sure thing, squashed and trailing whitespace removed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a guard on
@configbeingnilin theensureblock inload_config.This ensures the
Psych::SyntaxErroris properly surfaced when it is rescued and re-raised viafailure!since in that case@configwill not have been assigned yet when theensureblock runs.Fixes #304